Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incompatability with latest bwa due to tabs in @RG #100

Closed
EugeneBragin opened this issue Aug 11, 2017 · 4 comments
Closed

Incompatability with latest bwa due to tabs in @RG #100

EugeneBragin opened this issue Aug 11, 2017 · 4 comments
Assignees
Labels
Milestone

Comments

@EugeneBragin
Copy link

EugeneBragin commented Aug 11, 2017

$bwaopt .= qq{ -v 2 -M -R '\@RG\tID:$rgid\tSM:$rgid'};

line 214:
https://github.com/tseemann/snippy/blob/v3.1/bin/snippy#L214

This is double quoted string, which interpolates \t into actual tab, however latest bwa dies if it sees tabs there:
https://github.com/lh3/bwa/blob/master/bwa.c#L428

which could be clearly seen in the error log, among other warnings and messages:
[E::bwa_set_rg] the read group line contained literal characters -- replace with escaped tabs: \t

however this scenario is not handled and it keeps going further.

A simple double-escape of tab: $bwaopt .= qq{ -v 2 -M -R '\@rg\\tID:$rgid\\tSM:$rgid'};
solves the problem

@tseemann
Copy link
Owner

tseemann commented Aug 12, 2017

This was already fixed 11 days ago 34fab55
but I have not made a new release yet.

In fact I did exactly the same thing as you suggested:
+$bwaopt .= qq{ -v 2 -M -R '\@RG\\tID:$rgid\\tSM:$rgid'};
Great minds think alike!

Thanks for the report, it reminds me I need to make a new release.

@tseemann tseemann self-assigned this Aug 12, 2017
@tseemann tseemann added the bug label Aug 12, 2017
@tseemann tseemann added this to the Snippy 4.0 milestone Aug 12, 2017
@EugeneBragin
Copy link
Author

Thanks @tseemann
really good set of tools btw

@tseemann
Copy link
Owner

It will appear in official 3.2 release.

@sachalau
Copy link

sachalau commented Nov 2, 2017

@tseemann I'm running into the same problem using the bioconda version which is still 3.1. I was starting to update the bioconda recipe to upload the new release... before realizing I was a bit early :')
Do you have an idea regarding when you'll be able to release this new version ?
Thanks a lot for all the good work !
(pinging you because I don't know whether you receive notifs on closed issues, sorry)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants