Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: being able to post on a r-o channel. #1

Open
0x5c opened this issue Nov 28, 2017 · 7 comments
Open

Feature request: being able to post on a r-o channel. #1

0x5c opened this issue Nov 28, 2017 · 7 comments

Comments

@0x5c
Copy link

0x5c commented Nov 28, 2017

Basically allowing whitelisted users to directly post on a r-o channel.

@tshamz
Copy link
Owner

tshamz commented Feb 5, 2018

sure, this wouldn't be too difficult, where would you want to set who's on the whitelist? directly in the code or through the heroku env variables? and how would you like to set the user? by user ID or user name (my vote would be for user id but then it's a little harder to locate)?

@0x5c
Copy link
Author

0x5c commented Feb 6, 2018

For our use, IDs shouldn't be a problem as there wouldn't be a lot of "special users",although I can't speak for others who may want to use that feature.

Would it be possible to make a whitelist per protected channel? If yes, I think that either code/env, as long as it can take JSON input, would be good.

On a completely unrelated note, there is a relatively frequent disconnection bug that seems to emanate from botkit. I'll file a proper bug report once I manage to get on my computer and gather logs/relevant info.

@tshamz
Copy link
Owner

tshamz commented Feb 6, 2018 via email

@0x5c
Copy link
Author

0x5c commented Feb 7, 2018

Neat!

tshamz pushed a commit that referenced this issue Feb 8, 2018
@tshamz
Copy link
Owner

tshamz commented Feb 8, 2018

alright, i updated everything to now use, amongst other things:

  • the newer botkit starter kit
  • node LTS stuff
  • interactive messages + dialogs (so you don't have to deal with that weird message formatting)
  • and whitelisting users for posting in certain channels

the flow looks like this:

screen shot 2018-02-07 at 9 37 59 pm

screen shot 2018-02-07 at 9 38 08 pm

screen shot 2018-02-07 at 9 38 16 pm

I still have a little more work to do:

  • i need add the listener that deletes messages (which is also where I'll put in the check for who posted the message and deciding whether or not to delete their post)
  • im also thinking about just rolling this out as a dumb little free app in the slack marketplace, so i gotta put some stuff in place for that also

if you want take what i have right now and just finish it up on your own, you can find it in the #update-to-new-botkit-and-node branch.

i'll update you when everything is finished. enjoy!

@tshamz
Copy link
Owner

tshamz commented Feb 8, 2018

oooooooo, i almost forgot, everything works a little differently now so the whole config has been changed. When i get some more free time on my hands i'll get around to updating the readme.

@0x5c
Copy link
Author

0x5c commented Feb 8, 2018

Woooaaaaaaa! It's amazing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants