Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update SLiM script for verification.py #2126

Closed
GertjanBisschop opened this issue Nov 17, 2022 · 4 comments
Closed

update SLiM script for verification.py #2126

GertjanBisschop opened this issue Nov 17, 2022 · 4 comments

Comments

@GertjanBisschop
Copy link
Member

The current SLiM scripts in verification.py throw up a few errors when run with SLiM 4.0 (default installed version is the latest version of SLiM). For example, the concept of time/generations has been modified slightly, sim.generation can no longer be called to track time.

The version of SLiM used for statistical tests needs to specified explicitly and the scripts require some minor tweaks if we go with version 4.

@jeromekelleher
Copy link
Member

There's a makefile to download and compile SLiM, so perhaps we should just stick a particular version on that download (something < 4) and make sure that the verification.py will always use that?

@GertjanBisschop
Copy link
Member Author

Yup. Just for completeness. Had a little look, the actual modifications are minor.
Explicitly add 1 early() to the event populating the simulation. And replace sim.generation with sim.cycle.

@jeromekelleher
Copy link
Member

Great, thanks. I don't mind which direction we go.

@GertjanBisschop
Copy link
Member Author

Solved in #2315 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants