-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docs proofread #339
Docs proofread #339
Conversation
Only change to code is to import |
One comment: the phrase "loopy belief propagation" as used here Line 74 in 183363a
doesn't make much sense to me-- I've always seen LBP used to refer to a method (apply belief propagation repeatedly to graphs with loops) rather than as a "theoretical problem", per se. So my vote is to remove references to LBP from |
I'm having issues building the docs locally, so haven't yet checked to see if the links all work. |
@Mergifyio rebase |
☑️ Nothing to do
|
Ah, good point about the terminology. I will try to reword. I think we should make the point that the previous methods (without iterative convergence) were not exact, however. |
I'll merge this and fix any refs plus address the LBP stuff in a follow-up PR |
Some suggested changes to the docs wrt the variational gamma method.