-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tree-sequence-level metadata #534
Comments
By the way, would we ever want tree-specific metadata @benjeffery ? There's really no place for this. We would need a separate "tree" table. |
We'd need a clear and compelling justification for this - everything is fundamentally built around the idea that individual trees aren't important, it's the nodes and edges. |
Yes, I generally agree. The recent foray into BEAST trees (thanks a lot for looking into this @jeromekelleher) was my initial thought for this, but since that didn't really pan out, I can't think of any immediate justification at the moment, other than people are used to annotating specific trees with additional information. In general I agree that we should force them to think otherwise, though |
For easy reference, the discussion in #495 details some of the uses of ts-level metadata, and some discussion of how we might want it to work. |
Once #534 is complete, if the user really wanted per-tree metadata it could be stored as an array in the tree-sequence metadata. As this is not a common use-case I think that should suffice. |
Good call @benjeffery, that's a very pragmatic idea. |
As discussed in #491 it would be useful to have top-level metadata, using the same schema and encodings as row-level metadata. #491 is already a large PR so this will be done separately.
The text was updated successfully, but these errors were encountered: