-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement improved mrca. #1313
Implement improved mrca. #1313
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1313 +/- ##
=======================================
Coverage 93.81% 93.81%
=======================================
Files 26 26
Lines 22189 22174 -15
Branches 1006 1006
=======================================
- Hits 20816 20803 -13
+ Misses 1340 1338 -2
Partials 33 33
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The algorithm looks good to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, great stuff.
PInging @JSaha20 as it was mentioned she would be interested in the changes.
This pull request has been merged with the This option will be ignored starting May 1st, 2021, and removed This option can be replaced by |
Closes #1309
Implements @feilchenfeldt's beautifully elegant mrca algorithm discussed in #1306
Would you mind taking a look at the diff please @feilchenfeldt?