Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change "causal_state" to "causal_allele"? #113

Closed
jeromekelleher opened this issue Nov 20, 2023 · 1 comment
Closed

Change "causal_state" to "causal_allele"? #113

jeromekelleher opened this issue Nov 20, 2023 · 1 comment
Milestone

Comments

@jeromekelleher
Copy link
Member

When writing this up, I found "causal allele" much easier to explain, and on reflection, I don't see any reason to use causal_state (other than to mirror the tskit terminology). I think it's much clearer what our model is if we use "causal allele" throughout.

Also go through the documentation and remove references to "causal mutation", as this is incorrect (we can have multiple causal mutations to the causal allele).

@jeromekelleher jeromekelleher added this to the 0.0.2 release milestone Nov 20, 2023
@daikitag
Copy link
Collaborator

I agree with that, and I will change it really soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants