Update max_heaser_data from default(4K) to 20K #163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Also related to #4 |
shohey1226
changed the title
nuwang
added a commit
to CloudVE/ttyd
that referenced
this pull request
Mar 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've experienced
Ran out of header data spacewhile I have multiple sessions stored in my development server. (The different http servers runs on 3000,5000 and 8080 and stored cookie as a single domain) .From an issue, libwebsocket has options to increase this. For now, just increase 5 times bigger than default(4096), which is sufficient for the most of the case, I believe.
Cookie section of request header is fat and it seems no way to control header from websocket JS api.
