Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Bool in plist generation. #1827

Merged
merged 2 commits into from
Sep 27, 2020
Merged

Fix Bool in plist generation. #1827

merged 2 commits into from
Sep 27, 2020

Conversation

fortmarek
Copy link
Member

Resolves #1784

Short description 📝

There is a bug in Swiftgen inline-swift5 template where Bool is not converted from Int representation. It seems to be a known issue - I'll try to push the same fix there, too, but since we have the templates bundled in tuist, we can fix it right away.

Solution 📦

Use Boo.init(truncating:) if the metadata.type is a Boolean

Implementation 👩‍💻👨‍💻

  • Modify fixture to catch this bug
  • Fix it

Copy link
Collaborator

@jeroenleenarts jeroenleenarts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll run this against our codebase no later then 12:00 cest.

But I think LGTM.

@pepicrft pepicrft merged commit 4ffce76 into master Sep 27, 2020
@pepicrft pepicrft deleted the bugfix/plist_bool branch September 27, 2020 17:54
@jeroenleenarts
Copy link
Collaborator

When I remove disableSynthesizedResourceAccessors from our codebase's Config.swift it results in a compiling project. All bools match up with their sources.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

When resources are generated with 1.18.0, they contain compile errors
3 participants