Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Homebrew runs on M1 #2711

Merged
merged 3 commits into from
Mar 26, 2021
Merged

Fix Homebrew runs on M1 #2711

merged 3 commits into from
Mar 26, 2021

Conversation

pepicrft
Copy link
Contributor

Fixes #2704

Short description 📝

As mentioned here, tuist up fails to run brew because the Homebrew path is different in M1 laptops. As suggested by @fortmarek, I'm updating the code to let env determine the right brew version.

Checklist ✅

  • The code architecture and patterns are consistent with the rest of the codebase.
  • The changes have been tested following the documented guidelines.
  • The CHANGELOG.md has been updated to reflect the changes. In case of a breaking change, it's been flagged as such.
  • In case the PR introduces changes that affect users, the documentation has been updated.

@pepicrft pepicrft requested review from fortmarek and a team March 26, 2021 11:56
@pepicrft pepicrft self-assigned this Mar 26, 2021
@pepicrft pepicrft requested review from luispadron and removed request for a team March 26, 2021 11:56
Copy link
Collaborator

@luispadron luispadron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

Copy link
Contributor

@ferologics ferologics left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Curious if the "/usr/bin/ruby" on line 50 in UpHomebrew.swift should also be using the "/usr/bin/env" to check for correct path?

@pepicrft
Copy link
Contributor Author

Curious if the "/usr/bin/ruby" on line 50 in UpHomebrew.swift should also be using the "/usr/bin/env" to check for correct path?

That one should be updated too :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't run tuist up on M1
4 participants