Added codegen support for source file #3448
Conversation
| // | ||
| // FileCodeGen.swift | ||
| // FileCodeGen | ||
| // | ||
| // Created by Mahadevaiah, Pavan | Pavan | ECMPD on 2021/09/14. | ||
| // |
There was a problem hiding this comment.
minor: Worth removing this for consistency with the rest of the codebase where all header comments are omitted
| @@ -168,7 +168,8 @@ extension TuistGraph.Target { | |||
| let allSources = try TuistGraph.Target.sources(targetName: targetName, sources: manifest.sources?.globs.map { glob in | |||
| let globPath = try generatorPaths.resolve(path: glob.glob).pathString | |||
| let excluding: [String] = try glob.excluding.compactMap { try generatorPaths.resolve(path: $0).pathString } | |||
| return TuistGraph.SourceFileGlob(glob: globPath, excluding: excluding, compilerFlags: glob.compilerFlags) | |||
| let mappedCodeGen = TuistGraph.FileCodeGen.from(manifest: glob.codeGen) | |||
There was a problem hiding this comment.
minor: an alternate form that can mitigate the need to deal with optionals in the from method would be
let mappedCodeGen = glob.codeGen.map(TuistGraph.FileCodeGen.from)There was a problem hiding this comment.
Would you please bit more detailed code the above snippet returns FileCodeGen??
There was a problem hiding this comment.
Ah sorry, meant that would help make the from method be non optional:
e.g.
static func from(manifest: ProjectDescription.FileCodeGen) -> TuistGraph.FileCodeGen {
// ...
}| @@ -14,7 +14,13 @@ final class TargetTests: XCTestCase { | |||
| bundleId: "bundle_id", | |||
| deploymentTarget: .iOS(targetVersion: "13.1", devices: [.iphone, .ipad]), | |||
| infoPlist: "info.plist", | |||
| sources: "sources/*", | |||
| sources: [ | |||
There was a problem hiding this comment.
this particular test intentionally had sources: "sources/*" as it was verifying sources is able to accept string literals (for backward compatibility).
For this particular PR, updating test_toJSON_withFileList should suffice
| let model = MyModel() | ||
| model.save() | ||
| model.load() |
There was a problem hiding this comment.
Does this compile?
For this fixture, it would be handy to import Intents and used one of the codegened intent types.
There was a problem hiding this comment.
Yes it compiles actually i copied this folder, but let me update this code to use intent
| /// - `project`: project codegen attribute `settings = {ATTRIBUTES = (project_codegen, )}` | ||
| /// - `disabled`: disabled codegen attribute `settings = {ATTRIBUTES = (no_codegen, )}` | ||
| /// | ||
| public enum FileCodeGen: Codable, Equatable { |
There was a problem hiding this comment.
To support Xcode 12.5.1 (which doesn't yet support enum codable synthesis), we'll need to make this enum have a string raw value.
public enum FileCodeGen: String, Codable, Equatable
| /// - `project`: project codegen attribute `settings = {ATTRIBUTES = (project_codegen, )}` | ||
| /// - `disabled`: disabled codegen attribute `settings = {ATTRIBUTES = (no_codegen, )}` | ||
| /// | ||
| public enum FileCodeGen: Codable, Equatable { |
There was a problem hiding this comment.
same here (needs a string raw value)
kwridan
changed the title
|
Hey @pavm035, could you please align your branch with main so that CI can pass? 🙏 |
|
@danyf90 Done can you please confirm |
Co-authored-by: Daniele Formichelli <df@bendingspoons.com>
Co-authored-by: Daniele Formichelli <df@bendingspoons.com>
Co-authored-by: Daniele Formichelli <df@bendingspoons.com>
Co-authored-by: Daniele Formichelli <df@bendingspoons.com>
Added Filecodegen to support source file attributes in settings
Since we have few special type source files like
intentdefinitionandmlmodelsthat supports adding codegen attributes in settingsChecklist ✅
CHANGELOG.mdhas been updated to reflect the changes. In case of a breaking change, it's been flagged as such.