Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix zipping and unzipping cached frameworks with symlinks #4355

Merged
merged 15 commits into from
May 6, 2022

Conversation

fortmarek
Copy link
Member

@fortmarek fortmarek commented Apr 10, 2022

Short description 📝

This PR contains two things:

  • turning on the cloud in Config.swift
  • fixing the issue of using mac frameworks which were missing symlink -> that then resulted into Module not found errors

Checklist ✅

  • The code architecture and patterns are consistent with the rest of the codebase.
  • The changes have been tested following the documented guidelines.
  • The PR includes the label changelog:added, changelog:fixed, or changelog:changed, whenever it should be included in the “Added”, “Fixed” or “Changed” section of the CHANGELOG. Note: when included in the CHANGELOG, the title of the PR will be used as entry, please make sure it is clear and suitable.
  • In case the PR introduces changes that affect users, the documentation has been updated.
  • In case the PR introduces changes that affect how the cache artifact is generated starting from the TuistGraph.Target, the Constants.cacheVersion has been updated.

@fortmarek fortmarek force-pushed the cloud/turn-on branch 2 times, most recently from 7eb2fa9 to 2712791 Compare April 27, 2022 20:55
@fortmarek fortmarek marked this pull request as ready for review May 5, 2022 18:11
@fortmarek fortmarek added the changelog:fixed PR will be listed in the Fixed section of CHANGELOG label May 5, 2022
@fortmarek fortmarek changed the title Turn on cloud config Fix zipping and unzipping cached frameworks with symlinks May 5, 2022
@fortmarek fortmarek merged commit ff14419 into main May 6, 2022
@fortmarek fortmarek deleted the cloud/turn-on branch May 6, 2022 07:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog:fixed PR will be listed in the Fixed section of CHANGELOG
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants