Fix documentation generation #783
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested review from
kwridan and
ollieatkinson
and removed request for
a team
|
@pepibumur your pull request is missing a changelog! |
|
Is it possible to trigger a website workflow action for this P/R to ensure it passes before merging this. Since this P/R has not edited any of the website, only documentation there's no way to validate the action will pass. I can see from the code it's almost identical to the documentation action so we should be fine. |
Good idea. I just pushed a minor change to force the building of the website. |
|
Weird, it didn't trigger 🤷♂️ |
|
Good that you brought up that idea @ollieatkinson |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description 📝
It's not the first time documentation generation breaks so besides fixing the issue, I'm also adding 2 GitHub actions workflows to make sure that both, documentation and website build.