Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

document enforceRequestTimeout #955

Closed
pimpelsang opened this issue Nov 12, 2020 · 2 comments · Fixed by #1337
Closed

document enforceRequestTimeout #955

pimpelsang opened this issue Nov 12, 2020 · 2 comments · Fixed by #1337
Labels

Comments

@pimpelsang
Copy link
Contributor

pimpelsang commented Nov 12, 2020

A thing I found very confusing and took some time to debug out.

In documentation there is requestTimeout: 30000,
https://kafka.js.org/docs/configuration#request-timeout

But it is not applied as there is another undocumented configuration parameter

"enforceRequestTimeout" which is false by default.

So by default without even checking timeouts setting requestTimeout param has no effect at all :-)

Why not turn on timeout checks by default? Or at least mention in docs that there is another param to set

@tulios
Copy link
Owner

tulios commented Nov 12, 2020

That's a fair point, we introduced this property some time ago because we had performance issues when creating individual timers, but this was already solved. We should document the property and plan to make the default true in a major version bump.

The PR that fixed the individual timers: #650

@goriunovphl
Copy link

FYI we have been running our production system for quite a while with this flag on (after specified PR) and have not had any issues with performance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants