Add single requestTimeout runner instead of setTimeout per request #650
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I will fix tests properly if you are happy to process with this solution :) |
Nevon
requested changes
Mar 6, 2020
goriunov
commented
Mar 8, 2020
Nevon
reviewed
Mar 9, 2020
goriunov
commented
Mar 9, 2020
|
This looks really good now, in my opinion. |
Nevon
approved these changes
Mar 11, 2020
|
Thanks for the contribution! There will be a pre-release version out once the master build is done (https://dev.azure.com/tulios/kafkajs/_build/results?buildId=747&view=results). It should be version |
|
👍 Definitely will try to run it within next few week. Thanks :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP, open for discussions
Propose change to
requestTimeoutlogic to have separate runner which will check every inflight request everyxms. This is more performant than previous implementation and allow to enable requestTimeout for every single request without sacrificing performance much