Sub-directory support (fixes #5) #7
Conversation
| try { | ||
| return fs.statSync(fp).isDirectory() | ||
| } catch(err) { | ||
| } catch (err) { |
There was a problem hiding this comment.
This is simply the commit from #6 merged in.
| var path = require('path') | ||
| var modules = require('global-modules') | ||
| var cwd = process.cwd() | ||
| var getPkgDir = require('pkg-dir').sync |
There was a problem hiding this comment.
| "devDependencies": { | ||
| "assertit": "^0.1.0" | ||
| "assertit": "^0.1.0", | ||
| "mkdirp": "^0.5.1" |
There was a problem hiding this comment.
|
|
||
| 'use strict' | ||
|
|
||
| var mkdirp = require('mkdirp') |
There was a problem hiding this comment.
| test.equal(actual2, expected) | ||
| done() | ||
| process.chdir('..') | ||
| }) |
There was a problem hiding this comment.
All of these tests are simply duplicates of the "local" tests, with changing of the directory (and returning it afterwards).
|
I just was thinking to allow users to pass different cwd through options. Will this work for your case? I just don't want locking to some of these deps. Also find-up is slow. Thanks for the tests, I'll get them in new release. |
|
I think new updates resolves this case and proof is in 1c26584 :) Will close, let me know if something is not okey. |
|
Thank you! |
3 participants
No description provided.