Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Type might be incorrect for column id in table gcp_compute_disk. closes #218 #228

Merged
merged 1 commit into from
Jun 16, 2021

Conversation

ParthaI
Copy link
Contributor

@ParthaI ParthaI commented Jun 16, 2021

Note: Id column column type was double so the extra Zeros were being added in the end of the value, so converted it to Int

Integration test logs

Logs
Add passing integration test logs here

Example query results

Results

With column type Double

selece name, id from gcp_compute_disk;
+----------------+---------------------+
| name           | id                  |
+----------------+---------------------+
| raj-cis-test2  | 9032020956267478000 |
| raj-cis-test3  | 6514447256340713000 |
| raj-cis-test-3 | 404602883300363100  |
+----------------+---------------------+

With column type Int

selece name, id from gcp_compute_disk;
+----------------+---------------------+
| name           | id                  |
+----------------+---------------------+
| raj-cis-test2  | 9032020956267478221 |
| raj-cis-test3  | 6514447256340713201 |
| raj-cis-test-3 | 404602883300363041  |
+----------------+---------------------+

@ParthaI ParthaI requested a review from Subhajit97 June 16, 2021 05:10
@ParthaI ParthaI self-assigned this Jun 16, 2021
@ParthaI ParthaI linked an issue Jun 16, 2021 that may be closed by this pull request
Copy link
Contributor

@Subhajit97 Subhajit97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Type might be incorrect for column id in table gcp_compute_disk.
3 participants