Update tables for better use of API filters, context cancellation in list calls and page limiting for limit clause in query. Closes #336 #337
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gcp/table_gcp_compute_instance.go
Outdated
| @@ -312,7 +312,11 @@ func listComputeInstances(ctx context.Context, d *plugin.QueryData, h *plugin.Hy | |||
| limit := d.QueryContext.Limit | |||
| if d.QueryContext.Limit != nil { | |||
| if *limit < *pageSize { | |||
| pageSize = limit | |||
There was a problem hiding this comment.
Remove the line no 309 plugin.Logger(ctx).Trace("listComputeInstances", "IAM I HERE")
| limit := d.QueryContext.Limit | ||
| if d.QueryContext.Limit != nil { | ||
| if *limit < *pageSize { | ||
| if *limit < 1 { |
There was a problem hiding this comment.
Revisit -- do we need this in GCP?
| if *limit < *pageSize { | ||
| if *limit < 1 { | ||
| pageSize = types.Int64(1) | ||
| } else { |
There was a problem hiding this comment.
pageSize = types.Int64(1)
} else ```
Revisit as GCP does not have any limit issue, we have not experienced this.
rajlearner17
approved these changes
Jan 13, 2022
| if len(filters) > 0 { | ||
| filterString = strings.Join(filters, " ") | ||
| } | ||
| plugin.Logger(ctx).Trace("listComputeBackendBuckets", "filter string", filterString) |
There was a problem hiding this comment.
Suggested change
| plugin.Logger(ctx).Trace("listComputeBackendBuckets", "filter string", filterString) |
| if len(filters) > 0 { | ||
| filterString = strings.Join(filters, " ") | ||
| } | ||
| plugin.Logger(ctx).Trace("listComputeBackendServices", "filter string", filterString) |
There was a problem hiding this comment.
Suggested change
| plugin.Logger(ctx).Trace("listComputeBackendServices", "filter string", filterString) |
gcp/table_gcp_compute_firewall.go
Outdated
| if len(filters) > 0 { | ||
| filterString = strings.Join(filters, " ") | ||
| } | ||
| plugin.Logger(ctx).Trace("listComputeFirewalls", "filter string", filterString) |
There was a problem hiding this comment.
Suggested change
| plugin.Logger(ctx).Trace("listComputeFirewalls", "filter string", filterString) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tables
Integration test logs
integration_test.txt
Example query results
output.txt