-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add column access_approval_settings to table gcp_project closes #378 #381
Conversation
gcp/table_gcp_project.go
Outdated
@@ -61,6 +62,13 @@ func tableGcpProject(_ context.Context) *plugin.Table { | |||
Description: "A list of labels attached to this project.", | |||
Type: proto.ColumnType_JSON, | |||
}, | |||
{ | |||
Name: "access_approval", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As per the API, the column name should be access_approval_settings
. Also, please update the description to ` The access approval settings associated with a project.
gcp/table_gcp_project.go
Outdated
Name: "access_approval", | ||
Description: "Gets the settings associated with a project.", | ||
Type: proto.ColumnType_JSON, | ||
Hydrate: getProjectAccessapproval, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hydrate: getProjectAccessapproval, | |
Hydrate: getProjectAccessApprovalSettings, |
Integration test logs
Logs
Example query results
Results