Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add column access_approval_settings to table gcp_project closes #378 #381

Merged
merged 10 commits into from
Aug 16, 2022

Conversation

ParthaI
Copy link
Contributor

@ParthaI ParthaI commented Aug 12, 2022

Integration test logs

Logs
N/A

Example query results

Results
> select name, access_approvals from gcp_project
+------------+------------------+
| name       | access_approval  |
+------------+------------------+
| abcdef-aaa | <null>           |
+------------+------------------+

> select name, access_approval from gcp_project
+------------+--------------------------------------------------------------------------------------------------------------------------------------------------------------------
| name       | access_approval                                                                                                                                                   
+------------+--------------------------------------------------------------------------------------------------------------------------------------------------------------------
| parker-aaa | {"enrolledServices":[{"cloudProduct":"all","enrollmentLevel":"BLOCK_ALL"}],"name":"projects/parker-aaa/accessApprovalSettings","notificationEmails":["abcd@gmail.c
+------------+---------------------------------------------------------------------------------------------------------------------------------------

@ParthaI ParthaI linked an issue Aug 12, 2022 that may be closed by this pull request
@ParthaI ParthaI changed the title Issue 378 Add column access_approvals to table gcp_project closes #378 Aug 12, 2022
@ParthaI ParthaI changed the title Add column access_approvals to table gcp_project closes #378 Add column access_approval to table gcp_project closes #378 Aug 12, 2022
@@ -61,6 +62,13 @@ func tableGcpProject(_ context.Context) *plugin.Table {
Description: "A list of labels attached to this project.",
Type: proto.ColumnType_JSON,
},
{
Name: "access_approval",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As per the API, the column name should be access_approval_settings. Also, please update the description to ` The access approval settings associated with a project.

Name: "access_approval",
Description: "Gets the settings associated with a project.",
Type: proto.ColumnType_JSON,
Hydrate: getProjectAccessapproval,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Hydrate: getProjectAccessapproval,
Hydrate: getProjectAccessApprovalSettings,

@misraved misraved merged commit 69d36e8 into main Aug 16, 2022
@misraved misraved deleted the issue-378 branch August 16, 2022 13:23
@misraved misraved changed the title Add column access_approval to table gcp_project closes #378 Add column access_approval_settings to table gcp_project closes #378 Aug 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add column access_approval to table gcp_project
3 participants