Gcp cloud functions gen2 flooding

[ashutoshmore658]

Fixes #579 issue

[ParthaI]

@ashutoshmore658, please take a look at the review comments. Thanks!

[ParthaI]

@ashutoshmore658, is a separate transform function necessary? Wouldn't transform.FromField("State") suffice?

[ashutoshmore658]

No it would not suffice, I have checked it, but if you say, I will check it again.
Thank you.

[ParthaI]

Hello @ashutoshmore658, I've taken another look at the changes made to this table. I can confirm that, using the default transform function transform.FromField("State") is good for us, and there's no need to define a separate transform function for populating the column value.

Here is the result with the default transform function.

> select name, status from gcp_cloudfunctions_function
+------------------+--------+
| name             | status |
+------------------+--------+
| function-1-gen-2 | ACTIVE |
| function-1-gen-1 | ACTIVE |

Is there any special case where we are not getting the status column value with the default transform function?

[ParthaI]

@ashutoshmore658, I've made some additional observations, please have a look:

• The column values for runtime, available_memory_mb, build_id, entry_point, ingress_settings, max_instances, service_account_email, timeout, vpc_connector, and vpc_connector_egress_settings can be populated using the default transform function.
• The available_memory_mb column should be of type string, rather than int.
• For the columns source_upload_url and https_trigger, a separate transform function may be necessary, as the API does not return these properties directly.
• Considering we are uncertain of how users are utilizing this table in their setups, it might be prudent to refrain from modifying existing column values. Instead, adding new columns based on the API responses we receive could be more beneficial.

Please feel free to reach out if you have any questions or need further clarification.

Thank you!

[ParthaI]

Hello @ashutoshmore658, I've taken another look at the changes made to this table. I can confirm that, using the default transform function transform.FromField("State") is good for us, and there's no need to define a separate transform function for populating the column value.

Here is the result with the default transform function.

> select name, status from gcp_cloudfunctions_function
+------------------+--------+
| name             | status |
+------------------+--------+
| function-1-gen-2 | ACTIVE |
| function-1-gen-1 | ACTIVE |

Is there any special case where we are not getting the status column value with the default transform function?

[ashutoshmore658]

@ParthaI sure, let me take a look at this. Thank you for the valuable feedback.
also let me do a POC with the changes you are suggesting, because before going this way I tried with your approach but it was populating null values for these columns. So I decided to code by this way.

[ashutoshmore658]

@ParthaI actually I have tried by modifying code, checked with multiple times restarting the system(to avoid cached builds),
I am getting null for the columns,
it is working for the status only.
please have a look at the following test screenshot

[ParthaI]

Hello, @ashutoshmore658, I am not sure what the issue is with your system. I can see the result for all of the columns as mentioned here.

Note: I have renamed the column environment_variables to service_environment_variables to distinguish between the two types of environment variables: one for build and one for service. I am not retrieving the build_environment_variables because I have not configured it.

I have pushed the tested code to the branch test-gcp-cloud-function-table-column. Please feel free to take a look.

Thanks!

[ashutoshmore658]

Sure @ParthaI , I will test and lets merge it if it looks fine and okay to merge.

[ParthaI]

Hi @ashutoshmore658, Did you get a chance to retake a look at it?