Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for retrieving specific file content in the github_repository_content table Closes #444 #445

Merged
merged 3 commits into from
Aug 7, 2024

Conversation

ParthaI
Copy link
Contributor

@ParthaI ParthaI commented Jul 23, 2024

Example query results

Results
> select type, name, path, path_raw,mode, line_count from github_repository_content where repository_full_name = 'turbot/steampipe-plugin-github' and path = 'docs/tables/github_audit_log.md'
+------+---------------------+---------------------------------+----------------------------------------------+------+------------+
| type | name                | path                            | path_raw                                     | mode | line_count |
+------+---------------------+---------------------------------+----------------------------------------------+------+------------+
| blob | github_audit_log.md | docs/tables/github_audit_log.md | ZG9jcy90YWJsZXMvZ2l0aHViX2F1ZGl0X2xvZy5tZA== | 0    | 204        |
+------+---------------------+---------------------------------+----------------------------------------------+------+------------+

misraved
misraved previously approved these changes Jul 26, 2024
@misraved misraved dismissed their stale review July 26, 2024 14:35

In retrospection, the code requires some more updates.

@misraved
Copy link
Contributor

@ParthaI the implementation does not look correct since the two columns mentioned in the comment below are not returned by the GetConfig.

Reference - https://github.com/turbot/steampipe-plugin-github/pull/445/files#diff-b859c63e62f546ae6b1c4203d02d7866bc5172eb74f7a57d201aa21c74a705c1R140

Will it be possible to raise an issue with the GitHub API/Graphql team to add the following two fields in the response?

@ParthaI
Copy link
Contributor Author

ParthaI commented Jul 30, 2024

@misraved, I have pushed a commit to consistently populate the is_generated and mode column values.

Commit reference: 881047a

Could you please review the changes and let me know if everything looks good?

Thanks!

@misraved misraved merged commit 618095a into main Aug 7, 2024
1 check passed
@misraved misraved deleted the issue-444 branch August 7, 2024 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Retrieve a specific file within a repository returns no record
2 participants