Bugfix error and faketime #16
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix exiting with an error regardless of success status.
Check for root and provide a useful error message if not.
Ensure faketime uses a reliable and reproducible timestamp.
FYI the timestamp for faketime was coming from the last changelog entry, however pool generates the changelog file dynamically so that is not reproducible. If the source is a git repo, it now uses the mtime of
debian/controlfile. It was a somewhat arbitrary choice, but the file will always exist. FYI I had to use git log to get the "real" mtime because the mtime from the local filesystem is clone/last local update. If it's not a git repo, it falls back to the previous default behavior (i.e. last changelog entry).