Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in rplidar.dae #320

Merged
merged 2 commits into from
May 29, 2024
Merged

Fix typo in rplidar.dae #320

merged 2 commits into from
May 29, 2024

Conversation

galou
Copy link
Contributor

@galou galou commented Dec 6, 2023

Description

Color could not be parsed.

Fixes # (issue).

Fix importing with pycollada.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Open with CROSS.

Checklist

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation

Signed-off-by: Gaël Écorchard <gael@km-robotics.cz>
@galou
Copy link
Contributor Author

galou commented Jan 22, 2024

Any comment?

@hilary-luo
Copy link
Contributor

@galou Apologies for the delay. This is on my list of things to review but unfortunately other items have taken priority. For what it is worth though if you update / rebase now it should be able to succeed the ci.

@hilary-luo hilary-luo merged commit 1d23084 into turtlebot:humble May 29, 2024
@galou galou deleted the fix_rplidar.dae branch May 31, 2024 06:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants