-
-
Notifications
You must be signed in to change notification settings - Fork 390
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Panning a zoomed-in image stops under certain conditions #2297
Comments
I would love to see this fixed. Especially crippling for very wide or very high images. |
Hi, we are aware that image viewer (still) doesn't work as expected, we might need to replace/rewrite it again |
I'm gonna give this issue a bump, as I really like using Tusky and this is the number one thing bothering me regularly scrolling through the Fediverse 😬 |
nikclayton
added a commit
that referenced
this issue
Jul 31, 2023
Migrate to touchimageview from photoview, and adjust the touch logic to correctly handle single finger drag, two finger pinch/stretch, flings, taps, and swipes. As before, the features are: - Single tap, show/hide controls and media description - Double tap, zoom in/out - Single finger drag up/down, scale/translate image, dismiss if scrolled too far - Single finger drag left/right - When not zoomed, swipe to next image if multiple images present - When zoomed, scroll to edge of image, then to next image if multiple images present - Two finger pinch/zoom, zoom in/out on the image Behaviour differences to previous code 1. Bug fix: The image can't get "stuck" when zoomed, and impossible to scroll 2. Bug fix: Pinching is not mis-interpreted as a fling, closing the image 3. Bug fix: The zoom state of images is not lost or misinterpreted when the user swipes through multiple images 4. Bug fix: Double-tap zooms all the way, instead of stopping 5. Tapping outside the image does not dismiss it, controls and description show/hide Fixes #3562, #2297
Fixed in #3894 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Steps to reproduce:
It seems that the application confuses the upper edge meeting the end of the screen with the side edge meeting the end of the screen.
Here's a video of that:
https://video.kuba-orlik.name/videos/watch/ad085c55-deaf-4e31-859e-44f678512bdb
Tusky Version: 15.1
Android Version: 11
Android Device: Pixel 3a
I searched or browsed the repo’s other issues to ensure this is not a duplicate.
The text was updated successfully, but these errors were encountered: