Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Panning a zoomed-in image stops under certain conditions #2297

Closed
1 task done
kuba-orlik opened this issue Jan 19, 2022 · 4 comments
Closed
1 task done

Panning a zoomed-in image stops under certain conditions #2297

kuba-orlik opened this issue Jan 19, 2022 · 4 comments
Labels
bug
Milestone
Tusky 24

Comments

@kuba-orlik
Copy link

Steps to reproduce:

  1. Find a post with an image attached
  2. Open the image
  3. Zoom in the image so its height is larger than the screen height
  4. Pan the image so the upper edge of the image is aligned with the upper edge of the screen
  5. Try to pan the image left or right while moving the finger slightly downwards
  6. See that the panning is stopped as if there is no more picture in that direction (even though there is)

It seems that the application confuses the upper edge meeting the end of the screen with the side edge meeting the end of the screen.

Here's a video of that:

https://video.kuba-orlik.name/videos/watch/ad085c55-deaf-4e31-859e-44f678512bdb

  • Tusky Version: 15.1

  • Android Version: 11

  • Android Device: Pixel 3a

  • I searched or browsed the repo’s other issues to ensure this is not a duplicate.
@cobratbq
Copy link

cobratbq commented Mar 1, 2022

I would love to see this fixed. Especially crippling for very wide or very high images.

@charlag charlag added the bug label May 10, 2022
@charlag
Copy link
Collaborator

charlag commented May 10, 2022

Hi, we are aware that image viewer (still) doesn't work as expected, we might need to replace/rewrite it again

@Lakoja Lakoja mentioned this issue Apr 24, 2023
Closed
1 task
@9Lukas5
Copy link

9Lukas5 commented Jun 17, 2023

I'm gonna give this issue a bump, as I really like using Tusky and this is the number one thing bothering me regularly scrolling through the Fediverse 😬

nikclayton added a commit that referenced this issue Jul 31, 2023
Fix image zoom / pan / scroll / swipe (#3894)
79ee2dc 
Migrate to touchimageview from photoview, and adjust the touch logic to correctly handle single finger drag, two finger pinch/stretch, flings, taps, and swipes.

As before, the features are:

- Single tap, show/hide controls and media description
- Double tap, zoom in/out
- Single finger drag up/down, scale/translate image, dismiss if scrolled too far
- Single finger drag left/right
  - When not zoomed, swipe to next image if multiple images present
- When zoomed, scroll to edge of image, then to next image if multiple images present
- Two finger pinch/zoom, zoom in/out on the image

Behaviour differences to previous code

1. Bug fix: The image can't get "stuck" when zoomed, and impossible to scroll
2. Bug fix: Pinching is not mis-interpreted as a fling, closing the image
3. Bug fix: The zoom state of images is not lost or misinterpreted when the user swipes through multiple images
4. Bug fix: Double-tap zooms all the way, instead of stopping
5. Tapping outside the image does not dismiss it, controls and description show/hide

Fixes #3562, #2297
@nikclayton
Copy link
Contributor

Fixed in #3894

@charlag charlag added this to the Tusky 24 milestone Nov 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
Tusky 24
Development

No branches or pull requests
5 participants
@nikclayton @cobratbq @kuba-orlik @charlag @9Lukas5