Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switching apps while video is playing leaves UI in inconsistent, unpleasant state #4073

Closed
mcclure opened this issue Oct 24, 2023 · 2 comments
Closed

Switching apps while video is playing leaves UI in inconsistent, unpleasant state #4073

mcclure opened this issue Oct 24, 2023 · 2 comments

Comments

@mcclure
Copy link
Collaborator

mcclure commented Oct 24, 2023 •
edited
Loading

Perform the following steps

  • Start a video playing.
  • Hide the top (caption) and bottom (play controls) bars. (In the below video, I do this by waiting three seconds.)
  • Switch to another app within Android.
  • Switch back to Tusky.

Observed behavior: exactly ONE of the top and bottom bars will appear. If you tap, instead of dismissing as usual, it will toggle with each tap back and forth between exactly ONE of the top and bottom bars appearing, but it will switch back and forth. Once you are in this state the only way out is to either hit "back", or to wait three seconds for the bars to hide on their own.

This is clearly wrong, as well as frustrating.

This video is taken on Tusky 23.0 from the app store. However, I also see an identical problem on a self-built "develop" branch from today (with the exoplayer conversion).

Note: The video shows a screen recording of Tusky playing a video of a screen recording. This might be a little confusing.

screen-20231024-120849.mp4
@mcclure mcclure mentioned this issue Oct 24, 2023
Merged
@mcclure
Copy link
Collaborator Author

mcclure commented Oct 24, 2023

I can also get into this state by just rapidly tapping. Yikes.

mcclure added a commit to mcclure/Tusky that referenced this issue Nov 23, 2023
@mcclure
Fix issue tuskyapp#4073, leaving app while video playing then returni…
4f8dd33 
…ng leaves player/description UI in inconsistent state.

As part of implementing this, I: (1) standardized all hide queueing into the Play operation, removing two redundant hide queues (2) added logic so that if you suspend/resume after specifically requesting the player UI be shown, it doesn't hide itself.
@mcclure mcclure mentioned this issue Nov 23, 2023
Merged
@mcclure
Copy link
Collaborator Author

mcclure commented Nov 23, 2023

See discussion of cause in #4117

@Tak Tak closed this as completed in 70725fd Nov 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mcclure