Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slugify termation category #256

Merged
merged 1 commit into from
Jul 11, 2024
Merged

Slugify termation category #256

merged 1 commit into from
Jul 11, 2024

Conversation

PrenSJ2
Copy link
Member

@PrenSJ2 PrenSJ2 commented Jul 9, 2024

Close #255

Description

create sanitise_string to modify a sting into to the expected output of django's slugify

We use this for the terminaion_category

Testing

  • setup with termination_category customfield on tc2
  • set the termination for a cligency which has a company in hermes and org on pd
  • then update the org, bdr_person_id or something to trigger the webhook back to tc2
  • see that no api error occured

@PrenSJ2 PrenSJ2 self-assigned this Jul 9, 2024
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.59%. Comparing base (88f8a0d) to head (34db386).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #256      +/-   ##
==========================================
+ Coverage   93.56%   93.59%   +0.02%     
==========================================
  Files          29       29              
  Lines        1756     1763       +7     
  Branches      242      243       +1     
==========================================
+ Hits         1643     1650       +7     
  Misses         71       71              
  Partials       42       42              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@PrenSJ2 PrenSJ2 assigned DanJezeph15 and unassigned PrenSJ2 Jul 9, 2024
Copy link
Contributor

@DanJezeph15 DanJezeph15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

Copy link
Contributor

@HenryTraill HenryTraill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@HenryTraill HenryTraill assigned PrenSJ2 and unassigned HenryTraill Jul 10, 2024
@PrenSJ2 PrenSJ2 merged commit f10c1a7 into main Jul 11, 2024
2 checks passed
@PrenSJ2 PrenSJ2 deleted the slugify-termination-category branch July 11, 2024 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Termination Category handling apostrophes
4 participants