Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shared exclusion implementation for all existing quality measures #440

Merged
merged 112 commits into from
Apr 30, 2024

Conversation

deepsonshrestha
Copy link
Contributor

@deepsonshrestha deepsonshrestha commented Apr 19, 2024

Describe your changes

This PR aims to implement the shared exclusion logic for all the existing quality measures.

How has this been tested?

This was tested by querying against the production summary_counts table and same numbers were generated.

select
    prod.measure_id,
    prod.exclusion_sum as prod_exclusion_sum,
    shared_implementation.exclusion_sum as shared_implementation_exclusion_sum
from dev_utsav.quality_measures.summary_counts as shared_implementation
inner join dev_deepson.quality_measures.summary_counts as prod
    on prod.measure_id = shared_implementation.measure_id;

image

Reviewer focus

Palliative concept names are inconsistent across different measures. However only the concept names incorporated in the production have been used.

Checklist before requesting a review

  • I have updated the version number in dbt_project.yml file to reflect the release number of this PR
  • I have updated the docs files (by running dbt docs generate/serve and copying the necessary files into the docs folder)
  • I have commented my code as necessary
  • I have added at least one Github label to this PR
  • My code follows style guidelines
  • (Optional) I have recorded a Loom to explain this PR

(Optional) Gif of how this PR makes you feel

Loom link

deepsonshrestha and others added 30 commits March 11, 2024 17:52
…alth#429)

* add new clinical concepts

* add new observation models

* add new observation models

* add observation model to final list

* update models yml

* increment package version and update dbt docs

* remove diabetes in pregnancy codes

* fix observation staging and casting issues
@sarah-tuva sarah-tuva self-requested a review April 22, 2024 17:36
@sarah-tuva
Copy link
Member

sarah-tuva commented Apr 22, 2024

Hey @deepsonshrestha, I ran this branch on one of our customer datasets, and I'm getting some differences in counts that we need to look at. Check Slack for screenshots of the comparisons with main.

Can you look at your changes again? The two measures that seem to be affected are NQF0034 and NQF2372.

Copy link

Workflow has finished with the following statuses:

  • Snowflake: success
  • Snowflake: success
  • Snowflake: success
  • Redshift: success
  • Redshift: success
  • Redshift: success
  • BigQuery: success
  • BigQuery: success
  • BigQuery: success

@sarah-tuva
Copy link
Member

We are good to go with this PR. With the latest version of the branch, I was able to validate against real data and confirmed that the differences in exclusion reasons were mostly related to changes in descriptions. The CI tests passed as well. Merging this one in!

@sarah-tuva sarah-tuva merged commit f3a8866 into tuva-health:main Apr 30, 2024
Copy link

@Sunnyinho Sunnyinho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

End of line 😉

, exclusion_flag
, '{{ var('tuva_last_run')}}' as tuva_last_run
from add_data_types

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

EOL

tuvaforrest pushed a commit that referenced this pull request May 7, 2024
* feat: changed exclusions

* feat: shared exclusions for hospice and snp

* feat: shared exclusions for frailty

* feat: added common exclusion models and materialized as tables

* docs: updated schema names

* feat: updated the project version

* refactor: changed the schema names and removed older excluion logic

* docs: updated the tuva version

* feat: updated the seed files

* feat: deno models

* feat: created denominator model and updated perf period

* feat: updated both deno conditions

* docs: updated the docs and specified the schema

* osteo_numerator_procedure_only

* schema definition for nqf0053 numerator in yml

* changed codes from fracture diagnoses to procedures

* pharmacy_claims-numerator initial

* fix: refactored the source tables and updated the lookback period logic

* feat: numerator from procedure and pharmacy_claims

* minor: aesthetic changes

* Add observation suspecting logic for HCC 48 - Morbid Obesity (#429)

* add new clinical concepts

* add new observation models

* add new observation models

* add observation model to final list

* update models yml

* increment package version and update dbt docs

* remove diabetes in pregnancy codes

* fix observation staging and casting issues

* minor: denominator encounter filters

* feat: updated encounter type

* feat: numerator untested

* feat: numerator with recorded date from deno

* feat: updated emergency encounter type

* feat: created custom exclusions for NQF0053

* docs: updated the docs and specified the schema

* revert: reverted ED in encounter type

* feat: numerator and denominator

* feat: added lookback period for december

* docs: 0053 numerator column description added in yml

* minor: lookback fieldname change

* feat: 0053 long model and docs

* docs: staging medication table column update yml

* refactor: combined two same ctes into one

* minor: numerator

* feat: created exclusion model

* feat: updated long table

* feat: exclusions_utsav

* docs: exclusion yaml

* feat: exclusion with shared exclusion name updated

* feat: added final exclusion table

* feat: added nqf0053 in summary tables

* docs: removed unused columns

* fix: removed unused columns in NQf0059 diabetes

* docs: updated the tuva project version to 0.7.17

* minor: #15 pull request aesthetic changes

* docs: updated seed with rx code ndc

* feat: nqf0053 PR changes

* feat: added age and exclusion type for measure specific exclusion

* feat: implemeted shared exclusion and refactored the code

* docs: removed unused columns from schema.yml

* feat: updated the exclusions table

* docs: updated the columns

* removed older files

* feat: denominator PR changes

Co-authored-by: Sarah Morgan <sarah@tuvahealth.com>

* prune: removed unused frailty exclusion

* docs: tuva version update

* feat: exclusion PR changes

* fix: shared palliative concept added

* fix: Palliative care diagnosis added in nqf2372 exclusion

* docs: updated fields of 2372_exclusions, pruned unused model description

* feat: implemented shared exclusion for NQF2372

* fix: performance period issue

* fix: nqf2372 exclusion's fields edits in long model

* feat: updated palliative concept name according to value concept seed

* feat: implemented shared exclusion logic

* prune: removed unused exclusion tables and updated the docs

* BUGFIX: Correct union logic for shared exclusions in Quality Measures  (#437)

fix union logic

* Add HCC suspecting logic for CKD (#432)

* adding staging model for lab result

* adding intermediate models lab suspects

* add lab suspects to final model

* update package version and dbt docs

* update data type for lab results

* add data_source to join for egfr lab suspect logic

* update package version and dbt docs

* NQF0053 Osteoporosis Management in women who had a fracture (#436)

* feat: changed exclusions

* feat: shared exclusions for hospice and snp

* feat: shared exclusions for frailty

* feat: added common exclusion models and materialized as tables

* docs: updated schema names

* feat: updated the project version

* refactor: changed the schema names and removed older excluion logic

* docs: updated the tuva version

* feat: updated the seed files

* feat: deno models

* feat: created denominator model and updated perf period

* feat: updated both deno conditions

* docs: updated the docs and specified the schema

* osteo_numerator_procedure_only

* schema definition for nqf0053 numerator in yml

* changed codes from fracture diagnoses to procedures

* pharmacy_claims-numerator initial

* fix: refactored the source tables and updated the lookback period logic

* feat: numerator from procedure and pharmacy_claims

* minor: aesthetic changes

* Add observation suspecting logic for HCC 48 - Morbid Obesity (#429)

* add new clinical concepts

* add new observation models

* add new observation models

* add observation model to final list

* update models yml

* increment package version and update dbt docs

* remove diabetes in pregnancy codes

* fix observation staging and casting issues

* minor: denominator encounter filters

* feat: updated encounter type

* feat: numerator untested

* feat: numerator with recorded date from deno

* feat: updated emergency encounter type

* feat: created custom exclusions for NQF0053

* docs: updated the docs and specified the schema

* revert: reverted ED in encounter type

* feat: numerator and denominator

* feat: added lookback period for december

* docs: 0053 numerator column description added in yml

* minor: lookback fieldname change

* feat: 0053 long model and docs

* docs: staging medication table column update yml

* refactor: combined two same ctes into one

* minor: numerator

* feat: created exclusion model

* feat: updated long table

* feat: exclusions_utsav

* docs: exclusion yaml

* feat: exclusion with shared exclusion name updated

* feat: added final exclusion table

* feat: added nqf0053 in summary tables

* docs: removed unused columns

* fix: removed unused columns in NQf0059 diabetes

* docs: updated the tuva project version to 0.7.17

* minor: #15 pull request aesthetic changes

* docs: updated seed with rx code ndc

* feat: nqf0053 PR changes

* feat: denominator PR changes

Co-authored-by: Sarah Morgan <sarah@tuvahealth.com>

* docs: tuva version update

* feat: exclusion PR changes

---------

Co-authored-by: Deepson Shrestha <shresthadeepson317@gmail.com>
Co-authored-by: Deepson Shrestha <53638102+deepsonshrestha@users.noreply.github.com>
Co-authored-by: Sarah Morgan <sarah@tuvahealth.com>

* Patch 0.7.17 (#439)

* docs: revert package version

* fix: reorder columns

* docs: update dbt docs

* docs: update dbt docs

* fix: remove trailing blank rows

* BUGFIX: Correct union logic for shared exclusions in Quality Measures  (#437)

fix union logic

* Add HCC suspecting logic for CKD (#432)

* adding staging model for lab result

* adding intermediate models lab suspects

* add lab suspects to final model

* update package version and dbt docs

* update data type for lab results

* add data_source to join for egfr lab suspect logic

* update package version and dbt docs

* NQF0053 Osteoporosis Management in women who had a fracture (#436)

* feat: changed exclusions

* feat: shared exclusions for hospice and snp

* feat: shared exclusions for frailty

* feat: added common exclusion models and materialized as tables

* docs: updated schema names

* feat: updated the project version

* refactor: changed the schema names and removed older excluion logic

* docs: updated the tuva version

* feat: updated the seed files

* feat: deno models

* feat: created denominator model and updated perf period

* feat: updated both deno conditions

* docs: updated the docs and specified the schema

* osteo_numerator_procedure_only

* schema definition for nqf0053 numerator in yml

* changed codes from fracture diagnoses to procedures

* pharmacy_claims-numerator initial

* fix: refactored the source tables and updated the lookback period logic

* feat: numerator from procedure and pharmacy_claims

* minor: aesthetic changes

* Add observation suspecting logic for HCC 48 - Morbid Obesity (#429)

* add new clinical concepts

* add new observation models

* add new observation models

* add observation model to final list

* update models yml

* increment package version and update dbt docs

* remove diabetes in pregnancy codes

* fix observation staging and casting issues

* minor: denominator encounter filters

* feat: updated encounter type

* feat: numerator untested

* feat: numerator with recorded date from deno

* feat: updated emergency encounter type

* feat: created custom exclusions for NQF0053

* docs: updated the docs and specified the schema

* revert: reverted ED in encounter type

* feat: numerator and denominator

* feat: added lookback period for december

* docs: 0053 numerator column description added in yml

* minor: lookback fieldname change

* feat: 0053 long model and docs

* docs: staging medication table column update yml

* refactor: combined two same ctes into one

* minor: numerator

* feat: created exclusion model

* feat: updated long table

* feat: exclusions_utsav

* docs: exclusion yaml

* feat: exclusion with shared exclusion name updated

* feat: added final exclusion table

* feat: added nqf0053 in summary tables

* docs: removed unused columns

* fix: removed unused columns in NQf0059 diabetes

* docs: updated the tuva project version to 0.7.17

* minor: #15 pull request aesthetic changes

* docs: updated seed with rx code ndc

* feat: nqf0053 PR changes

* feat: denominator PR changes

Co-authored-by: Sarah Morgan <sarah@tuvahealth.com>

* docs: tuva version update

* feat: exclusion PR changes

---------

Co-authored-by: Deepson Shrestha <shresthadeepson317@gmail.com>
Co-authored-by: Deepson Shrestha <53638102+deepsonshrestha@users.noreply.github.com>
Co-authored-by: Sarah Morgan <sarah@tuvahealth.com>

* Patch 0.7.17 (#439)

* docs: revert package version

* fix: reorder columns

* docs: update dbt docs

* docs: update dbt docs

* fix: remove trailing blank rows

* feat: NQF2372 exclusion filtered

* fix: syntax error

* refactor: shared hospice palliative reorder

* feat: added relevant concept names

* refactor: changed to lowercase

* docs: updated docs for NQF0034

* docs: 0034 yaml update

* docs: updated the docs

* docs: updated numerator for osteoporosis

* docs: updated yaml for 0053

* Update dbt_project.yml

* refactor: use existing cte for mastectomy

* fix: made changes to age irrelvant fields

* fix: shared exclusion acute inpatient filter

* refactor: mastectomy exclusion segregated

---------

Co-authored-by: utsavpaudel <utsavpaudel111@gmail.com>
Co-authored-by: Sarah Morgan <sarah@tuvahealth.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants