ISSUE #28: Bug with replay logic implementation. #29
Conversation
Fixed the issue, removed redundant addition of text object, as creating and rendering objects again and again is expensive.Now the overlapping of text in the pause state representation is not there in MotionCommotion and Migrating Flocks as shown in the snapshot. Tested on Firefox/Edge/Chrome.
|
|
||
| game.input.enabled=true; | ||
|
|
||
|
|
There was a problem hiding this comment.
Only those changes you made should be reflecting here. That would be easy for me and other contributors to check and verify your changes.
There was a problem hiding this comment.
Those are just lines with empty spaces that Atom itself has removed. Check that the code changes that has been made by me has been highlighted with a different more bright red/green color.
There was a problem hiding this comment.
Take a split view while viewing the diif it would be helpful.
|
Thanks @AkshayAgarwal007. But update your pull request as mentioned in the comment. |
|
Those are just lines with empty spaces that Atom itself has removed. Check that the code changes that has been made by me has been highlighted with a different more bright red/green color.Take a split view while viewing the diif it would be helpful. @Vigneshsekar |
Fixed the issue, removed redundant addition of text objects, as creating
and rendering game objects again and again is expensive.Now the overlapping of
text in the pause state representation is not there in MotionCommotion and
Migrating Flocks as shown in the snapshot. Tested on Firefox/Edge/Chrome. ISSUE #27 need to be fixed to make the replay code more generic.