Styled -> Apply #3
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 9 commits
January 20, 2021 17:50
…default props, various improvements
…west implementations
just214
added
documentation
sastan
reviewed
Feb 16, 2021
src/components/Input.tsx
Outdated
| import { __DEV__ } from '../utils'; | ||
|
|
||
| const SIZES_MAP = { | ||
| sm: 'px-3 py-1 text-xs', |
src/utils/index.ts
Outdated
| @@ -23,3 +24,7 @@ export const logClassNames = ( | |||
| console.log(classNames); | |||
| } | |||
| }; | |||
|
|
|||
| export function lazy(arg: TemplateStringsArray) { | |||
There was a problem hiding this comment.
This would only work for non-interpolated tagged templates. The following function would allow interpolations:
import type { Token } from 'twind';
function lazy(arg: TemplateStringsArray, ...interpolations: Token) {
return ({ tw }: Context) => tw(arg, ...interpolations);
}There was a problem hiding this comment.
Good call...I got in a bit of a rush and forgot to account for the interpolations.
|
That was fast. Great job! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses #2 , and updates all components to use currently available features (
tw,apply) until thestyledapi is officially released. Other changes include dependency updates, expanded props, and various component style refactors.