Card styles #22950
Merged
Card styles #22950
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…der-{color} utilities
…d color utilities
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes how we do card variants. Rather than generate custom classes for just the
.cardcomponent for changing thecolor,background-color, andborder-color, we're now using our utility classes. This provides more flexibility in how you ultimately style cards, while at the same time reducing our compiled CSS.Drops all card mixins. No more need for a
.card-dark—which also coincidentally conflicted with.card-darkfrom the$theme-colorsSass map—and no morecard-variantorcard-outline-variant.Replaces all
.card-{color}instances with a mix of.bg-{color}and.text-whiteas needed. For the outline ones, we're now using.border-{color}.Drops the
.card-blockquoteahead of Redesign blockquote #22949 shipping, which removes most of the styling that we were overriding with that class. Might need some margin utilities still, though.Docs have been updated, but might need to update the migration guide, too.