Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert issue #25687 (Docs Display Hiding elements) #25712

Merged
merged 1 commit into from
Mar 2, 2018

Conversation

josmaissan
Copy link
Contributor

@josmaissan josmaissan commented Feb 25, 2018

Roll back of issue #25687

docs/4.0/utilities/display.md
line 54, the example, now is:

To show an element only on a given interval of screen sizes you can combine one .d-*-none class with a .d-*-* class, for example .d-none .d-md-block .d-xl-block will hide the element for all screen sizes except on medium and large devices.
but also except on extra large devices

But has to be rolled back to:

To show an element only on a given interval of screen sizes you can combine one .d-*-none class with a .d-*-* class, for example .d-none .d-md-block .d-xl-none will hide the element for all screen sizes except on medium and large devices.

It will be visible on medium (md) and large (lg) devices and invisible on extra large (xl) devices

@josmaissan josmaissan mentioned this pull request Feb 25, 2018
@josmaissan josmaissan changed the title display on xl viewport docs/4.0/utilities/display Hiding elements Feb 25, 2018
@josmaissan josmaissan changed the title docs/4.0/utilities/display Hiding elements Revert issue #25687 (Docs Display Hiding elements) Feb 28, 2018
Copy link
Member

@mdo mdo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup, I didn't look close enough!

@mdo mdo merged commit 6431d74 into twbs:v4-dev Mar 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants