-
-
Notifications
You must be signed in to change notification settings - Fork 78.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix typo of example in hiding doc #25687
Conversation
@peterpeterparker @mdo There was no typo at all! 🤥 |
@josmaissan are you sure?
this doesn't match the explanation text "hide the element for all screen sizes except on medium and large devices" display on large devices = xl != .d-xl-none |
@peterpeterparker Sure! Large =! eXtra Large medium screens What you make of it could even be simplified to |
Why not, you do a PR with something like the following?
or
|
@peterpeterparker You don't understand how it works I think. |
@josmaissan ok, as you want @mdo you revert the PR or should I provide a new one to revert this? |
@peterpeterparker Hope you understand the mistake, otherwise I can make a PR for it |
@josmaissan be my guest, do the PR |
There was I think I small typo mistake in following sentence of the documentation
bootstrap/docs/4.0/utilities/display.md
To show an element only on a given interval of screen sizes you can combine one .d--none class with a .d--* class, for example .d-none .d-md-block .d-xl-none will hide the element for all screen sizes except on medium and large devices.
Therefore I modified
.d-xl-none
to.d-xl-block