Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo of example in hiding doc #25687

Merged
merged 1 commit into from
Feb 24, 2018
Merged

Fix typo of example in hiding doc #25687

merged 1 commit into from
Feb 24, 2018

Conversation

peterpeterparker
Copy link
Contributor

There was I think I small typo mistake in following sentence of the documentation bootstrap/docs/4.0/utilities/display.md

To show an element only on a given interval of screen sizes you can combine one .d--none class with a .d--* class, for example .d-none .d-md-block .d-xl-none will hide the element for all screen sizes except on medium and large devices.

Therefore I modified .d-xl-none to .d-xl-block

@mdo mdo merged commit 6708c4d into twbs:v4-dev Feb 24, 2018
@mdo mdo mentioned this pull request Feb 24, 2018
@josmaissan
Copy link
Contributor

josmaissan commented Feb 25, 2018

@peterpeterparker @mdo There was no typo at all! 🤥
🌀 Roll back to .d-none .d-md-block .d-xl-none please! 👍

@peterpeterparker
Copy link
Contributor Author

@josmaissan are you sure?

.d-none .d-md-block .d-xl-none doesn't display the content on large screen size because of .d-xl-none

this doesn't match the explanation text "hide the element for all screen sizes except on medium and large devices"

display on large devices = xl != .d-xl-none

@josmaissan
Copy link
Contributor

josmaissan commented Feb 25, 2018

@peterpeterparker Sure!

Large =! eXtra Large

medium screens .d-md-…
large screens is .d-lg-…
extra large screens is .d-xl-…
on V4

What you make of it could even be simplified to .d-none .d-md-block

@peterpeterparker
Copy link
Contributor Author

peterpeterparker commented Feb 25, 2018

Why not, you do a PR with something like the following?

To show an element only on a given interval of screen sizes you can combine one .d--none class with a .d--* class, for example .d-none .d-md-block will hide the element for all screen sizes except on medium devices.

or

To show an element only on a given interval of screen sizes you can combine one .d--none class with a .d--* class, for example .d-none .d-md-block .d-xl-block will hide the element for all screen sizes except on medium and extra large devices.

@josmaissan
Copy link
Contributor

josmaissan commented Feb 25, 2018

@peterpeterparker You don't understand how it works I think.
In this case it is
.d-none .d-sm-none .d-md-block .d-lg-block d-xl-none
simplified to
.d-none .d-md-block d-xl-none
Just a roll back will do. 🌀🤓

@peterpeterparker
Copy link
Contributor Author

@josmaissan ok, as you want

@mdo you revert the PR or should I provide a new one to revert this?

@josmaissan
Copy link
Contributor

josmaissan commented Feb 25, 2018

@peterpeterparker Hope you understand the mistake, otherwise I can make a PR for it

@peterpeterparker
Copy link
Contributor Author

@josmaissan be my guest, do the PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants