Remove tooltip and popover styling as it is handled by Popper #34627
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdo
reviewed
Jul 30, 2021
GeoSot
changed the title
GeoSot
force-pushed
the
gs-tooltip-css-tweaks
branch
from
56f6e46
to
a782de9
Compare
GeoSot
force-pushed
the
gs-tooltip-css-tweaks
branch
from
a782de9
to
702ffae
Compare
GeoSot
force-pushed
the
gs-tooltip-css-tweaks
branch
from
702ffae
to
c0811d5
Compare
XhmikosR
reviewed
Oct 9, 2021
mdo
force-pushed
the
gs-tooltip-css-tweaks
branch
from
c0811d5
to
3b347e2
Compare
XhmikosR
reviewed
Nov 23, 2021
GeoSot
force-pushed
the
gs-tooltip-css-tweaks
branch
2 times, most recently
from
a54c792
to
b6cc8d5
Compare
|
I noticed a case in RTL cheatsheet where the arrow is on the wrong side on small screen. Not quite sure what's happening but needs some diagnostics. As far as I remember, RTL needed the |
mdo
force-pushed
the
gs-tooltip-css-tweaks
branch
2 times, most recently
from
9134bab
to
55cdaea
Compare
|
@GeoSot If this is still good to go, want to take a crack at resolving conflicts and we can review once more before merging? |
GeoSot
force-pushed
the
gs-tooltip-css-tweaks
branch
from
55cdaea
to
4e42cc7
Compare
|
For v5 seems fine. As popper has been changed lately, I am not aware if theses changes will be reverted on BS v6 |
Remove tooltip margin variable, as popper needs margin to be zero
mdo
force-pushed
the
gs-tooltip-css-tweaks
branch
from
4e42cc7
to
f6a1a8f
Compare
mdo
approved these changes
Apr 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #35039
Popper.js suggests to avoid the usage of margins, so our variable, and some initializations are obsolete
Preview https://deploy-preview-34627--twbs-bootstrap.netlify.app/