-
-
Notifications
You must be signed in to change notification settings - Fork 78.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Android Chrome input date dimensions #36143
Conversation
6c8aee4
to
4968592
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See comments
234d3d0
to
73c81ec
Compare
73c81ec
to
83fdff0
Compare
83fdff0
to
1fefec6
Compare
Any news? |
1fefec6
to
1b36335
Compare
1b36335
to
ae7bcfe
Compare
Any news? |
Missed this myself. Is the width bug present in any other browser? I don’t have an Android to test myself. |
ae7bcfe
to
8ecff17
Compare
Visual tests js/tests/visual/input.html On macOS Monterey 12.6.2:
On Android 13 (Pixel 4):
On iOS 16.2 (iPhone 14 Pro Max Simulator):
The width problem on Safari iOS is also fixed by this PR: |
c44d271
to
d8e4c4f
Compare
Under Android Chrome, input date dimensions are broken:
Before 40px high vs 38px for the other inputs:
After 38px high:
I've tested by plugging in my Android device via USB then opened chrome://inspect/#devices (USB debugging must be enabled on the device).
Hence the need for an HTTP server