-
-
Notifications
You must be signed in to change notification settings - Fork 78.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New Sass variable to change vertical rule width #38886
Conversation
03260c7
to
a355cad
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about adding a new variable called $rule-border-width
?
$rule-border-width: var(--#{$prefix}border-width) !default;
$hr-border-width: $rule-border-width !default;
$vr-border-width: $rule-border-width !default;
You could also do the same with the $hr-opacity
since you most likely don't know it's used by the vertical rule without looking at the implementation. But that should maybe be another PR
Oops, meant to merge another branch. Oh well, this is probably fine to be in v5.3.1 anyway even though technically it's a new Sass variable. |
Description
This PR adds a new Sass variable (
$vr-border-width
) to customize the width of the vertical rule helper.Motivation & Context
Vertical rule helper should offer the same customization options as horizontal rule helper.
IMO, this new feature, if landed, should target v5.4.0.
Type of changes
Checklist
npm run lint
)Live previews
Related issues
Closes #38856