Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relationship between tags and record field names #12

Merged
merged 6 commits into from
Aug 20, 2018
Merged

Conversation

aherrmann
Copy link
Member

@aherrmann aherrmann commented Aug 10, 2018

closes #8

Following the direction of #28

  • Modifies Field and Pos such that the resulting tag matches the field name or position.
  • Adds a Rename combinator that allows to rename the tag e.g. from position 0 to tag "foo".
  • Updates the examples accordingly

@aherrmann aherrmann changed the title [WIP] Relationship between tags and record field names Relationship between tags and record field names Aug 17, 2018
Copy link
Member

@aspiwack aspiwack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It reads a bit weird that Rename mentions the old tag but not the new tag. But we can sort this out later.

@aherrmann
Copy link
Member Author

It reads a bit weird that Rename mentions the old tag but not the new tag. But we can sort this out later.

That's true. We could add the new tag as a parameter to Rename, but it would technically be redundant. The same is true for the field/pos parameter on Field/Pos. Currently, it's a redundant parameter. We should probably be consistent and either always or never have such technically redundant parameters.

@aherrmann aherrmann merged commit 01ba152 into master Aug 20, 2018
@aherrmann aherrmann deleted the ah/rename branch August 20, 2018 07:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Relationship between tags and record field names
2 participants