Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor jupyenv #524

Open
wants to merge 28 commits into
base: main
Choose a base branch
from
Open

Refactor jupyenv #524

wants to merge 28 commits into from

Conversation

GTrunSec
Copy link
Collaborator

@GTrunSec GTrunSec commented Oct 1, 2023

@GTrunSec GTrunSec requested a review from djacu as a code owner October 1, 2023 08:03
@netlify
Copy link

netlify bot commented Oct 1, 2023

Deploy Preview for tweag-jupyterwith ready!

Name Link
🔨 Latest commit 38ee7c1
🔍 Latest deploy log https://app.netlify.com/sites/tweag-jupyterwith/deploys/65c3fbc9464d210008adba0f
😎 Deploy Preview https://deploy-preview-524--tweag-jupyterwith.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@GTrunSec GTrunSec marked this pull request as draft October 1, 2023 08:15
@GTrunSec GTrunSec force-pushed the chore branch 3 times, most recently from 13b9db2 to c1e0601 Compare October 2, 2023 02:49
@GTrunSec GTrunSec changed the title Update jupyterlab Refactor jupyenv Oct 2, 2023
@GTrunSec GTrunSec marked this pull request as ready for review October 2, 2023 06:11
@GTrunSec GTrunSec force-pushed the chore branch 2 times, most recently from c09a9cb to 9d5eff0 Compare October 2, 2023 06:45
@GTrunSec
Copy link
Collaborator Author

GTrunSec commented Oct 2, 2023

@balsoft refactor-stage1 has been DONE.

@teto
Copy link
Contributor

teto commented Nov 3, 2023

I've tried to set extraHaskellPackages = p: [ p.bytestring p.text ] for the haskell kernel but if fails because those are null in nixpkgs and the option expects a function towards a list of packages

        extraHaskellPackages = lib.mkOption {
          type = types.functionTo (types.listOf types.package);
          default = _: [];

I think it would be less surprising to have

        extraHaskellPackages = lib.mkOption {
          type = types.functionTo (types.listOf (types.nullOr types.package));
          default = _: [];

@GTrunSec
Copy link
Collaborator Author

GTrunSec commented Nov 4, 2023

@teto Thanks, fixed

flake.nix Outdated Show resolved Hide resolved
@aniinbkln
Copy link

aniinbkln commented Jul 23, 2024

@GTrunSec , just wondering what work needs to be wrapped up here to push these changes. Is it just the failing haskell test that is blocking? I would love to help!

@GTrunSec
Copy link
Collaborator Author

@aniinbkln the building of Haskell is ok, just no maintainer(with the PR permission) in this project.

@cschar
Copy link

cschar commented Aug 26, 2024

mac m1 user awaiting fix ;)

inputs.opam-nix.inputs.flake-utils.follows = "flake-utils";
inputs.opam-nix.inputs.nixpkgs.follows = "nixpkgs";
inputs.pre-commit-hooks.url = "github:cachix/pre-commit-hooks.nix";
inputs.pre-commit-hooks.inputs.flake-utils.follows = "flake-utils";
inputs.pre-commit-hooks.inputs.nixpkgs.follows = "nixpkgs";
inputs.pre-commit-hooks.inputs.flake-compat.follows = "";
# https://github.com/nix-community/poetry2nix/pull/1329
inputs.poetry2nix.url = "github:nix-community/poetry2nix";
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably needs lock file update:

error: attribute 'overlays' missing
at /nix/store/cygya77xpaz7zxkdmr9klsgxfc1hc60y-source/flake.nix:71:11:
70| pkgs = nixpkgs.legacyPackages.${system}.appendOverlays [
71| poetry2nix.overlays.default
| ^
72| ];
Did you mean overlay?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature]: A "pure" python kernel
6 participants