Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow 9.6 #267

Merged
merged 3 commits into from
Mar 5, 2024
Merged

Allow 9.6 #267

merged 3 commits into from
Mar 5, 2024

Conversation

turion
Copy link
Collaborator

@turion turion commented May 10, 2023

Follow-up to #266 (should be merged first).

  • Clean up git history

@turion turion force-pushed the dev_ghc96 branch 5 times, most recently from 6bb7bfc to bd234a1 Compare May 10, 2023 14:48
@turion
Copy link
Collaborator Author

turion commented May 12, 2023

It seems that GHC 9.6 is nigh impossible because ListT is really, really gone from the ecosystem. I'll aim at 9.4 first and see whether we can get #245 resolved first.

@reubenharry
Copy link
Contributor

Surely the ListT code we need is fairly minimal though? Can't we just put it directly in the repo?

@turion
Copy link
Collaborator Author

turion commented May 16, 2023

If there is no great hurry to support GHC 9.6 right away I'd rather go with the clean solution from the start.

@turion turion mentioned this pull request May 16, 2023
@turion
Copy link
Collaborator Author

turion commented May 16, 2023

I'll aim at 9.4 first

This is #271

@turion turion changed the title Allow GHC 9.4 and 9.6 Allow 9.6 May 17, 2023
@turion turion mentioned this pull request Jan 2, 2024
2 tasks
@turion turion force-pushed the dev_ghc96 branch 2 times, most recently from 4a66c40 to 9bef9eb Compare January 3, 2024 16:25
@turion turion force-pushed the dev_ghc96 branch 3 times, most recently from a0313f7 to 36731a4 Compare January 18, 2024 15:59
Copy link
Contributor

@reubenharry reubenharry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing objectionable here from my perspective - glad to see 9.6 here though!

@turion turion enabled auto-merge March 5, 2024 13:52
@turion turion merged commit d5689f5 into tweag:master Mar 5, 2024
5 checks passed
@turion turion deleted the dev_ghc96 branch March 5, 2024 16:50
@turion turion mentioned this pull request Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants