Support other bases than decimal for num literals #1798
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds support in the parser for number literals in hexadecimal, octal and binary notation, suitably prefixed with the common `0x`, `0b` and `0o`. The documentation of the manual is updated accordingly.
jneem
approved these changes
Feb 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1796.
This PR adds support in the parser for number literals in hexadecimal, octal and binary notation, suitably prefixed with the common
0x,0band0o. The documentation of the manual is updated accordingly.The stdlib function
std.string.to_numberwasn't updated to handle those new representations. I'm not sure yet if we should or if it should be a different function, accepting for example a baseb. Or do both (maketo_numberthe more generic but add more focused functions for specific bases or notations). In the meantime, I stuck to the most restrictive choice. We can reconsider later.