Parametrized list type #272
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yannham
force-pushed
the
feature/parametrized-lists
branch
from
b67455c
to
e65906d
Compare
Merged
aspiwack
approved these changes
Jan 25, 2021
| @@ -316,6 +318,19 @@ impl Types { | |||
| } | |||
| } | |||
| } | |||
|
|
|||
| /// Determine if a type is an atom, that is a either an atom or a type delimited by specific | |||
There was a problem hiding this comment.
This is a slightly confusing sentence.
It also feels like a bit overspecialised. More generally, you may need to know whether something has tighter priority than its surrounding or not. Not an urgent thing to fix, though.
Co-authored-by: Arnaud Spiwack <arnaud.spiwack@tweag.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #171. The list type is now parametrized by the type of its elements. The standard
Listis kept as an alias forList Dyn, both in the grammar and in error reporting messages. The list contract is updated and the types of the lists module of the stdlib are improved accordingly.This introduces a slight regression, that is the typechecker now rejects
[1, "a", false] : Listbecause currently nothing unifies with the dynamic type, unless an explicit case is used. We could make a special case to have this typecheck again, but it seems adhoc and is actually part of a bigger issue to think about, see #244 for example. Maybe bidirectional typechecking could also help here.