Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partly address #92. Depends on #97. This PR adds more specific variants to the error type
EvalError
, and moves the elaboration of error messages to a dedicated location, namely the implementation of the trait defined in #97. The evaluation code now passes elementary data through these variants rather than building error messages itself, wherever possible. The intended result is that error messages are more consistent and easier to improve in the future.Examples
Doing so, error messages have also been revamped although was not the main focus, and can still be improved. Blame error messages have not yet been modified. Here are a few examples of messages before and after this PR:
Before
Now