Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test ok -> fail #69

Closed
wants to merge 2 commits into from
Closed

Test ok -> fail #69

wants to merge 2 commits into from

Conversation

infinisil
Copy link
Member

No description provided.

@infinisil infinisil force-pushed the check-by-name-base-test-ok-fail branch from 2d47843 to ba71ce1 Compare September 27, 2023 23:32
@infinisil infinisil force-pushed the check-by-name-base-test-ok-fail branch from ba71ce1 to 52c8ac0 Compare September 27, 2023 23:34
@infinisil infinisil force-pushed the check-by-name-base-test-ok-fail branch from 52c8ac0 to 1f0147e Compare September 27, 2023 23:36
@infinisil infinisil force-pushed the check-by-name-base-test-ok-fail branch from 1f0147e to 6bff33e Compare September 27, 2023 23:51
@infinisil infinisil force-pushed the check-by-name-base-test-ok-fail branch from 6bff33e to 47667fe Compare September 27, 2023 23:54
@infinisil infinisil mentioned this pull request Sep 28, 2023
Merged
6 tasks
@infinisil infinisil force-pushed the check-by-name-base-test branch 4 times, most recently from b7e7b2d to faed0ab Compare October 2, 2023 19:27
@infinisil infinisil force-pushed the check-by-name-base-test-ok-fail branch from 47667fe to 71b46aa Compare October 2, 2023 19:27
@infinisil infinisil force-pushed the check-by-name-base-test-ok-fail branch from 71b46aa to e6ce079 Compare October 2, 2023 19:49
@infinisil
workflows/check-by-name: Better error when base branch also fails
a487747 
Previously, even if the check also failed on the base branch, it looked
like the PR introduced the failure.

We can easily have a better error message for such cases.

Meanwhile this also paves the road for something like
NixOS#256788
@infinisil infinisil force-pushed the check-by-name-base-test-ok-fail branch from e6ce079 to dd630b6 Compare October 2, 2023 19:51
@infinisil infinisil closed this Oct 4, 2023
@infinisil infinisil deleted the check-by-name-base-test-ok-fail branch October 4, 2023 22:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@infinisil