Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose a more complete API from the Ormolu module #976

Merged
merged 1 commit into from
Jan 25, 2023
Merged

Expose a more complete API from the Ormolu module #976

merged 1 commit into from
Jan 25, 2023

Conversation

mrkkrp
Copy link
Member

@mrkkrp mrkkrp commented Jan 20, 2023 •
edited
Loading

Close #970, close #971, close #924.

@mrkkrp mrkkrp requested a review from amesgen January 20, 2023 14:51
@mrkkrp
Copy link
Member Author

mrkkrp commented Jan 20, 2023

This is a step towards exposing pretty much all logic of Ormolu CLI from the Ormolu module and making it "official". It still requires some manual wiring from the user to do what the CLI does, because I wanted to keep the helpers versatile.

@mrkkrp mrkkrp marked this pull request as ready for review January 20, 2023 14:55
@amesgen amesgen mentioned this pull request Jan 21, 2023
Merged
amesgen
amesgen reviewed Jan 24, 2023
View reviewed changes
src/Ormolu/Utils/Fixity.hs Outdated Show resolved Hide resolved
@github-actions
Copy link

github-actions bot commented Jan 24, 2023 •
edited
Loading

🚀 Deployed on https://8e59392453620ea78d72655ae91d6fb5e647c9c4--ormolu-live.netlify.app

@github-actions github-actions bot temporarily deployed to pull request January 24, 2023 18:14 Inactive
@mrkkrp mrkkrp force-pushed the public-api branch 3 times, most recently from 3ec2a3d to 95b4629 Compare January 24, 2023 19:36
@github-actions github-actions bot temporarily deployed to pull request January 24, 2023 19:52 Inactive
amesgen
amesgen requested changes Jan 24, 2023
View reviewed changes
CHANGELOG.md Show resolved Hide resolved
src/Ormolu.hs Show resolved Hide resolved
src/Ormolu/Utils/Cabal.hs Show resolved Hide resolved
@mrkkrp mrkkrp force-pushed the public-api branch 4 times, most recently from 2777c6d to a4a8b60 Compare January 25, 2023 15:47
@mrkkrp mrkkrp requested a review from amesgen January 25, 2023 15:47
@github-actions github-actions bot temporarily deployed to pull request January 25, 2023 16:03 Inactive
amesgen
amesgen approved these changes Jan 25, 2023
View reviewed changes
expected-failures/default.nix Show resolved Hide resolved
app/Main.hs Outdated Show resolved Hide resolved
@mrkkrp @amesgen
Expose a more complete API from the Ormolu module
8e59392 
Co-authored-by: amesgen <alexander.esgen@tweag.io>
@github-actions github-actions bot temporarily deployed to pull request January 25, 2023 19:27 Inactive
@mrkkrp mrkkrp merged commit c81320d into master Jan 25, 2023
@mrkkrp mrkkrp deleted the public-api branch January 25, 2023 19:27
@amesgen amesgen mentioned this pull request Jan 27, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amesgen amesgen amesgen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

False positive - cabal doesn't have a ref to a source file Squash warnings about Setup.hs
2 participants
@mrkkrp @amesgen