Measure effect of not cleaning up linker flags #74
Labels
Comments
Fuuzetsu
pushed a commit
that referenced
this issue
Jan 2, 2018
This turns commands like ``` /nix/store/2yrbxj9n50vjvysblnkwffplh5ixmnp1-bash/bin/bash -c 'external/inline-java-toolchain/nix/bin/ghc $(realpath external/openjdk/nix/lib/openjdk/jre/lib/amd64/server/libjvm.so) $(realpath bazel-out/k8-fastbuild/bin/libbctable.a) $(realpath bazel-out/k8-fastbuild/bin/libbctable.so) -o bazel-out/k8-fastbuild/bin/jvm-streaming/spec bazel-out/k8-fastbuild/bin/jvm-streaming/libempty.a -optl bazel-out/k8-fastbuild/bin/jvm-streaming/objects-spec-1.0.0/Language/Java/StreamingSpec.o -optl bazel-out/k8-fastbuild/bin/jvm-streaming/objects-spec-1.0.0/Main.o -optl bazel-out/k8-fastbuild/bin/jvm-streaming/objects-spec-1.0.0/Spec.o -optl bazel-out/k8-fastbuild/bin/jvm-streaming/lib-jvm-streaming-1.0.0/libHSjvm-streaming-1.0.0.a -optl bazel-out/k8-fastbuild/bin/jni/lib-jni-1.0.0/libHSjni-1.0.0.a -optl bazel-out/k8-fastbuild/bin/lib-inline-java-1.0.0/libHSinline-java-1.0.0.a -optl bazel-out/k8-fastbuild/bin/jni/lib-jni-1.0.0/libHSjni-1.0.0.a -optl bazel-out/k8-fastbuild/bin/jvm/lib-jvm-1.0.0/libHSjvm-1.0.0.a -optl bazel-out/k8-fastbuild/bin/jni/lib-jni-1.0.0/libHSjni-1.0.0.a -optl bazel-out/k8-fastbuild/bin/jvm/lib-jvm-1.0.0/libHSjvm-1.0.0.a -optl bazel-out/k8-fastbuild/bin/jni/lib-jni-1.0.0/libHSjni-1.0.0.a -optl bazel-out/k8-fastbuild/bin/jvm/lib-jvm-1.0.0/libHSjvm-1.0.0.a -optl bazel-out/k8-fastbuild/bin/jni/lib-jni-1.0.0/libHSjni-1.0.0.a -optl bazel-out/k8-fastbuild/bin/lib-inline-java-1.0.0/libHSinline-java-1.0.0.a -optl bazel-out/k8-fastbuild/bin/jni/lib-jni-1.0.0/libHSjni-1.0.0.a -optl bazel-out/k8-fastbuild/bin/jvm/lib-jvm-1.0.0/libHSjvm-1.0.0.a -optl bazel-out/k8-fastbuild/bin/jni/lib-jni-1.0.0/libHSjni-1.0.0.a -package base -package bytestring -package choice -package containers -package constraints -package deepseq -package inline-c -package singletons -package distributed-closure -package exceptions -package text -package vector -package Cabal -package directory -package filepath -package filemanip -package ghc -package language-java -package mtl -package process -package template-haskell -package temporary -package streaming -package hspec') ``` into ``` /nix/store/2yrbxj9n50vjvysblnkwffplh5ixmnp1-bash/bin/bash -c 'external/inline-java-toolchain/nix/bin/ghc $(realpath external/openjdk/nix/lib/openjdk/jre/lib/amd64/server/libjvm.so) $(realpath bazel-out/k8-fastbuild/bin/libbctable.a) $(realpath bazel-out/k8-fastbuild/bin/libbctable.so) -o bazel-out/k8-fastbuild/bin/jvm-streaming/spec bazel-out/k8-fastbuild/bin/jvm-streaming/libempty.a -optl bazel-out/k8-fastbuild/bin/jvm-streaming/objects-spec-1.0.0/Language/Java/StreamingSpec.o -optl bazel-out/k8-fastbuild/bin/jvm-streaming/objects-spec-1.0.0/Main.o -optl bazel-out/k8-fastbuild/bin/jvm-streaming/objects-spec-1.0.0/Spec.o -optl bazel-out/k8-fastbuild/bin/jvm-streaming/lib-jvm-streaming-1.0.0/libHSjvm-streaming-1.0.0.a -optl bazel-out/k8-fastbuild/bin/lib-inline-java-1.0.0/libHSinline-java-1.0.0.a -optl bazel-out/k8-fastbuild/bin/jvm/lib-jvm-1.0.0/libHSjvm-1.0.0.a -optl bazel-out/k8-fastbuild/bin/jni/lib-jni-1.0.0/libHSjni-1.0.0.a -package base -package bytestring -package choice -package containers -package constraints -package deepseq -package inline-c -package singletons -package distributed-closure -package exceptions -package text -package vector -package Cabal -package directory -package filepath -package filemanip -package ghc -package language-java -package mtl -package process -package template-haskell -package temporary -package streaming -package hspec') ``` Possibly this has a positive performance impact on linking time (unconfirmed) but at the very least it makes checking through the command much easier. Fixes #74.
avdv
added a commit
that referenced
this issue
Oct 23, 2023
The zlib headers were part of streaming-commons but have been removed. See [#74]. [#74]: fpco/streaming-commons#74
avdv
added a commit
that referenced
this issue
Oct 23, 2023
The zlib headers were part of streaming-commons but have been removed. See [#74]. [#74]: fpco/streaming-commons#74
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Since 0bba4b8 I have a feeling my linking has been slower. Perhaps we really do want to clean these up before passing them to GHC: if library is mentioned multiple times, do we pay multiple times for it?
However I may be imagining it so this ticket is about measuring the impact on linking itself.
The text was updated successfully, but these errors were encountered: