Allow reexporting a package from a haskell_library
#1008
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As we discussed, no one is using this field, so go ahead and reuse it. |
|
I've renamed the old |
added 5 commits
August 2, 2019 08:01
Add a new `package_reexports` argument to `haskell_library` such that if a rule `foo` has `bar` in its `package_reexports`, every package that depends on `foo` will also implicitely depend on `bar`
thufschmitt
force-pushed
the
haskell_group
branch
from
b47c16a
to
8110cc3
Compare
We have two choices for the name of this field: follow Bazel convention or follow Cabal convention. We would normally do the former, but I would argue that there is no Bazel precedent in this case. For package reexports, we have the `exports` field like in Java. We could use the same precedent for module reexports, but for the following qualitatitve differences: * module reexports don't have the same type. We have to map labels for packages to reexport specs. * Module reexports aren't about targets per say, but rather parts of a target (aka a "package" in Cabal parlance). The rules don't really know about modules, only the compiler does. So for lack of established Bazel precedent, we follow Cabal precedent. This has the advantage that attributes that handle modules are all named the same way (`hidden_modules`, `reexported_modules`, etc).
mboes
approved these changes
Aug 5, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the re-opening of #757 (because github doesn't allow me to directly reopen it)
I eventually found the time to finish this.
I didn't reuse the
exportsfield since I find it a bit disturbing to suddenly change the meaning of an existing attribute, so the field is calledpackage_reexportsinstead.So the semantics now are that if a rule
foohaspackage_reexports = [ "bar ], thenfoowill depend onbar(as if it was in itsdepsfield)foowill seebaras if it was in its dependenciesfoo@replwill load both the modules offooandbar