Download Stack if possible #1011
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aherrmann
approved these changes
Jul 26, 2019
| return | ||
|
|
||
| # If we can't find Stack, download it. | ||
| (os, arch) = _get_platform(repository_ctx) |
There was a problem hiding this comment.
Should we detect NixOS and fail gracefully in that case? The bindist will probably fail with the usual and quite misleading "no such file or directory" error.
There was a problem hiding this comment.
Yeah, we should put this behind a flag and only enable it for bindists
There was a problem hiding this comment.
I don't know how to reliably detect NixOS. Maybe we could improve the error message in this case with hints? Being on NixOS will be the common case for why the binary failed...
If we don't find a recent enough Stack on the PATH, then just download one locally and use that. Since this is happening in a workspace rule, we have no choice but to use prebuilt binaries. This behaviour brings us closer to what rules_jvm_external does, which likewise downloads a tool used to compute the dependency graph. NixOS users will of course need to continue providing Stack in the shell, because the Stack bindists don't work there, or using the new `stack` attribute.
|
I improved the error message for NixOS users, but also made it possible for Nix users to supply Stack via |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we don't find a recent enough Stack on the PATH, then just download
one locally and use that. Since this is happening in a workspace rule,
we have no choice but to use prebuilt binaries. This behaviour brings
us closer to what rules_jvm_external does, which likewise downloads
a tool used to compute the dependency graph.
NixOS users will of course need to continue providing Stack in the
shell, because the Stack bindists don't work there.