Make compiler version check happen earlier #1014
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We use to have an action that all other actions depended on transitively: a compiler version check. We remove this check, which is redundant in the case of bindists, and happens too late in the case of Nixpkgs. We replace it with a new check that happens at workspace rule evaluation time, and which is Nixpkgs specific. Fixes #945
Profpatsch
approved these changes
Jul 30, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We use to have an action that all other actions depended on
transitively: a compiler version check. We remove this check, which is
redundant in the case of bindists, and happens too late in the case of
Nixpkgs. We replace it with a new check that happens at workspace rule
evaluation time, and which is Nixpkgs specific.
Fixes #945