Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sorted manifest files #1128

Merged
merged 1 commit into from
Oct 17, 2019
Merged

Sorted manifest files #1128

merged 1 commit into from
Oct 17, 2019

Conversation

guibou
Copy link
Contributor

@guibou guibou commented Oct 17, 2019

Fix for #1126.

find output is not stable, resulting on generated files with similar
content but in a different order.

This is not good for caching. The trivial solution is to use sort to
fix the output.

@guibou
Sorted manifest files
3a197a9 
Fix for #1126.

`find` output is not stable, resulting on generated files with similar
content but in a different order.

This is not good for caching. The trivial solution is to use `sort` to
fix the output.
aherrmann
aherrmann approved these changes Oct 17, 2019
View reviewed changes
Copy link
Member

@aherrmann aherrmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, good catch!

@aherrmann aherrmann added the merge-queue merge on green CI label Oct 17, 2019
@mergify mergify bot merged commit 01333db into master Oct 17, 2019
@mergify mergify bot deleted the reproducible_manifest branch October 17, 2019 14:57
@mergify mergify bot removed the merge-queue merge on green CI label Oct 17, 2019
@guibou guibou mentioned this pull request Oct 17, 2019
Closed
@mboes
Copy link
Member

mboes commented Oct 20, 2019

The addition of sort can seem useless at first blush, but is actually an important fix. You should therefore add a comment just above it to clarify that this is necessary to make the action output deterministic and reference #1126.

@guibou
Copy link
Contributor Author

guibou commented Oct 29, 2019

@mboes see #1135

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aherrmann aherrmann aherrmann approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@guibou @mboes @aherrmann