Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run CI in Docker container #12

Merged
merged 1 commit into from
Feb 19, 2020
Merged

Run CI in Docker container #12

merged 1 commit into from
Feb 19, 2020

Conversation

aherrmann
Copy link
Member

The buildkite workers are now running on NixOS. However, rules_sh should be tested outside a Nix environment (rules_nixpkgs provides the relevant Nix extensions). We follow rules_haskell's example and run the pipeline in a dedicated Docker container.

The buildkite workers are now running on NixOS. However, `rules_sh`
should be tested outside a Nix environment (`rules_nixpkgs` provides the
relevant Nix extensions). We follow `rules_haskell`'s example and run
the pipeline in a dedicated Docker container.
@mrkkrp
Copy link
Member

mrkkrp commented Feb 18, 2020

The build doesn't seem to get an agent because of monad-bayes. Hopefully later today we'll get free agents.

@aherrmann
Copy link
Member Author

@mrkkrp It got a free agent by now and succeeded.

@mboes
Copy link
Member

mboes commented Feb 19, 2020

I'm not sure I understand the requirement that this should be tested on anything that is not NixOS. Is it because we are using a Bazel bindist?

@aherrmann
Copy link
Member Author

I'm not sure I understand the requirement that this should be tested on anything that is not NixOS. Is it because we are using a Bazel bindist?

Yes, because we are using the Bazel bindist and because sh_posix_configure is intended for the non-Nix use-case. So, we want to test it in a non-Nix environment to make sure it works there.

For Nix users rules_nixpkgs provides nixpkgs_sh_posix_configure and rules_nixpkgs contains corresponding tests.

@aherrmann aherrmann added the merge-queue merge on green CI label Feb 19, 2020
@mergify mergify bot merged commit 3b522f6 into master Feb 19, 2020
@mergify mergify bot deleted the fix-ci branch February 19, 2020 10:34
@mergify mergify bot removed the merge-queue merge on green CI label Feb 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants