Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cargo install fails #690

Closed
ErinvanderVeen opened this issue Mar 13, 2024 · 1 comment · Fixed by #696
Closed

Cargo install fails #690

ErinvanderVeen opened this issue Mar 13, 2024 · 1 comment · Fixed by #696
Labels
P1 critical: next release type: bug

Comments

@ErinvanderVeen
Copy link
Collaborator

ErinvanderVeen commented Mar 13, 2024 •
edited
Loading

Describe the bug
Cargo install doesn't build because cargo install ignores the lockfile and can then not select the right tree-sitter version.

To Reproduce
cargo install

Expected behavior
Installed topiary

Environment

  • OS name + version: NixOS 23.11
  • Version of the code: main
@ErinvanderVeen ErinvanderVeen added type: bug P1 critical: next release labels Mar 13, 2024
@Jasha10
Copy link
Contributor

Jasha10 commented Mar 17, 2024 •
edited
Loading

I had success passing a --locked flag to the cargo install command.

cargo install --path topiary-cli --locked

@ErinvanderVeen ErinvanderVeen linked a pull request Apr 4, 2024 that will close this issue
fix: pin our grammar crates; update flake inputs #696
Merged
yannham added a commit to tweag/nickel that referenced this issue Apr 22, 2024
@yannham
Update to latest Topiary and tree-sitter-nickel
2c797b2 
For some reason, the version of Topiary and of the Nickel tree sitter
grammar were lagging behind, before the support for pattern matching was
added, which means current master wasn't able to format a file with
pattersn in it - maybe it was a rollback because of the Topiary install
issue (tweag/topiary#690).

The former issue has been fixed, so this commit update to latest Topiary
in order to get formatting of patterns.
@yannham yannham mentioned this issue Apr 22, 2024
Merged
github-merge-queue bot pushed a commit to tweag/nickel that referenced this issue Apr 23, 2024
@yannham
Update to latest Topiary and tree-sitter-nickel (#1893)
428447c 
For some reason, the version of Topiary and of the Nickel tree sitter
grammar were lagging behind, before the support for pattern matching was
added, which means current master wasn't able to format a file with
pattersn in it - maybe it was a rollback because of the Topiary install
issue (tweag/topiary#690).

The former issue has been fixed, so this commit update to latest Topiary
in order to get formatting of patterns.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
P1 critical: next release type: bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: pin our grammar crates; update flake inputs tweag/topiary
2 participants
@Jasha10 @ErinvanderVeen